[PATCH] [compiler-rt] Add ASan debugging API to get malloc/free stack traces and shadow memory mapping info

Alexander Potapenko glider at google.com
Tue Jul 15 01:49:29 PDT 2014


================
Comment at: test/asan/TestCases/debug_stacks.cc:28
@@ +27,3 @@
+  fprintf(stderr, "alloc stack retval %s\n", (num_frames > 0 && num_frames < 10)
+          ? "ok" : ""); // CHECK: alloc stack retval ok
+  fprintf(stderr, "thread id = %d\n", thread_id); // CHECK: thread id = 0
----------------
Kuba Brecka wrote:
> Alexander Potapenko wrote:
> > Please add a second space before "//" here and below.
> Not sure if you really just wanted another space, so moving the CHECKs to separate lines as done in all other test cases.
I was talking about two spaces between the code and the inline comment:

  ...);  // CHECK: ...

, which is used across the sanitizers codebase.
CHECKs on separate lines are also fine in this case.

http://reviews.llvm.org/D4466






More information about the llvm-commits mailing list