[PATCH] [ELF] Implement parsing `-l` prefixed items in the `GROUP` linker script command

Simon Atanasyan simon at atanasyan.com
Mon Jul 14 06:37:08 PDT 2014


* Fixed all minor problems line `const` qualifiers, local variable naming etc.
* Made the code which handles a library name `-l` shorter and more similar to the code handles a regular file names.
* Keep using the `unknown` token to indicate an unexpected input. The same approach is used by other parts of the lexer now.
* Added some new test cases.
* I decided to do not introduce new routines like `canStartLibraryName` to validate library names. Anyway we check this name later and report an error if this name is invalid. It is better than reject a valid name here by mistake. By the way BFD and Gold linker accept almost arbitrary names.

http://reviews.llvm.org/D4469

Files:
  include/lld/ReaderWriter/LinkerScript.h
  lib/Driver/GnuLdInputGraph.cpp
  lib/ReaderWriter/ELF/ELFLinkingContext.cpp
  lib/ReaderWriter/LinkerScript.cpp
  test/LinkerScript/libname-err-1.test
  test/LinkerScript/libname-err-2.test
  test/LinkerScript/linker-script.test
  test/elf/Inputs/group-cmd-search-3.ls
  test/elf/group-cmd-search.test
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D4469.11374.patch
Type: text/x-patch
Size: 8702 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140714/eef5440f/attachment.bin>


More information about the llvm-commits mailing list