[PATCH] [compiler-rt][builtins] CTest to execute builtins testsuite

Alexey Samsonov vonosmas at gmail.com
Fri Jul 11 18:09:40 PDT 2014

FWIW, I agree that it would bring more benefit to just port these tests to lit. The RUN-line for them would be similar and trivial (smth. like RUN: %clang %s -O2 -o %t && %t), and would allow us to test just-built Clang, which seems like the right thing to do (we'll also automatically test that Clang driver appropriately links in builtins library). RUN-lines are also suited to the special cases like "compile this file with -fnested-functions").

Comment at: test/builtins/CMakeLists.txt:193
@@ +192,3 @@
+foreach(arch x86_64 i386 arm ppc mips)
+  if(CAN_TARGET_${arch})
+    foreach (src ${GENERIC_SOURCES} ${${arch}_SOURCES})
Faraz Shahbazker wrote:
> Alexey Samsonov wrote:
> > please check COMPILER_RT_CAN_EXECUTE_TESTS here instead - we don't need to add targets otherwise.
> It is checked below for add_test(line 202). My plan was to be able to cross-build the test-suite even when we can't execute it. The dev environment is usually much faster and I think it might be useful to fix all build issues before moving to the target for execution.
> If this doesn't seem like a good idea, can we just remove the check from this file and modify the upper test/CMakeLists.txt instead? It already has a COMPILER_RT_CAN_EXECUTE_TESTS block. Enclosing add_subdirectory in that block should give the desired effect and be consistent with the way sanitizer tests are controlled.
Yes, the latter sounds good.


More information about the llvm-commits mailing list