[llvm] r212837 - Simplify the raw_svector_ostream tweak from r212816
Chandler Carruth
chandlerc at google.com
Fri Jul 11 11:47:09 PDT 2014
On Fri, Jul 11, 2014 at 11:23 AM, Alp Toker <alp at nuanti.com> wrote:
> Simplify the raw_svector_ostream tweak from r212816
>
> The memcpy() and overlap helps didn't help much with timings, so clean up
> the change.
>
> The difference at this point is that we now leave growth of the storage
> buffer
> up to SmallVector's implementation:
>
> - OS.reserve(OS.capacity() * 2);
> + OS.reserve(OS.size() + 64);
>
Thanks for fixing this, but in the future, it would be a lot easier to
review this kind of patch by reverting the original and then re-applying
just the cleanup portion of the patch.
-Chandler
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140711/ccd8ab01/attachment.html>
More information about the llvm-commits
mailing list