Fwd: [PATCH] PR19958 wrong code at -O1 and above on x86_64-linux-gnu (InstCombine)

[suyog sarda]

Adding Duncan

(Something wrong with phabricator, previous mail didn't include Duncan even
after adding him as reviewer.)

---------- Forwarded message ----------
From: suyog <suyog.sarda at samsung.com>
Date: Thu, Jul 10, 2014 at 1:55 AM
Subject: Re: [PATCH] PR19958 wrong code at -O1 and above on
x86_64-linux-gnu (InstCombine)
To: suyog.sarda at samsung.com, rafael.espindola at gmail.com, nlewycky at google.com,
spatel at rotateright.com
Cc: llvm-commits at cs.uiuc.edu


Hi Duncan,

Thanks for your explanation. I have handled case for 'lshr' separately now
in the patch attached.

I have combined the logic for ashr/lshr as well as exact/non-exact as most
of the logic is same.
Wherever there are special cases, i have handled them separately. I have
added the logic for the
cases which were handled by 'instsimplify' to keep the logical flow as
discussed.

I have combined the logic, since the 'match' functions are expensive, same
for the log,
and our whole point of calculating difference of log was to avoid expensive
division operation.

Please help in reviewing the patch. Your comments/suggestions are most
welcomed :)

http://reviews.llvm.org/D4068

Files:
  lib/Transforms/InstCombine/InstCombineCompares.cpp
  test/Transforms/InstCombine/icmp.ll

_______________________________________________
llvm-commits mailing list
llvm-commits at cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits




-- 
With regards,
Suyog Sarda
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140710/76c0a71b/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D4068.11217.patch
Type: text/x-patch
Size: 9565 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140710/76c0a71b/attachment.bin>