[PATCH] Make it possible for ints/floats to return different values from getBooleanContents()

hfinkel at anl.gov hfinkel at anl.gov
Wed Jul 9 12:35:37 PDT 2014

Assuming you take my suggestion regarding setBooleanContents (or otherwise make it so that the function-call order does not matter), LGTM. Thanks!

Comment at: include/llvm/Target/TargetLowering.h:974
@@ -956,1 +973,3 @@
+  /// See getBooleanContents.
+  void setBooleanFloatContents(BooleanContent Ty) { BooleanFloatContents = Ty; }
I'd really prefer that you do this as I suggested:
void setBooleanContents(BooleanContent Ty) { BooleanContents = Ty; BooleanFloatContents = Ty; }

void setBooleanContents(BooleanContent Ty, BooleanContent FTy) { BooleanContents = Ty; BooleanFloatContents = FTy; }

The reason is that, as you've implemented it, the order in which you call setBooleanContents and setBooleanFloatContents matters, and I think that will prove confusing.


More information about the llvm-commits mailing list