[PATCH] [AArch64] Implement Clang CLI interface proposal about "-march".

Eric Christopher echristo at gmail.com
Wed Jul 9 11:52:48 PDT 2014


One small inline comment.

================
Comment at: lib/Driver/Tools.cpp:1521
@@ +1520,3 @@
+                                  std::vector<const char *> &Features) {
+  SmallVector<StringRef, 8> Splited;
+  text.split(Splited, StringRef("+"), -1, false);
----------------
"Split" would be better, or "Splitted". I'd go for the first :)

http://reviews.llvm.org/D4346






More information about the llvm-commits mailing list