[PATCH] Templatify RegionInfo

Matt Arsenault arsenm2 at gmail.com
Tue Jul 8 21:35:34 PDT 2014

On Jul 8, 2014, at 4:06 PM, Tobias Grosser <tobias at grosser.es> wrote:

> On 08/07/2014 21:37, Chandler Carruth wrote:
>> So, I'm really fine with experiments going on in tree here, I just wanted
>> to know what the plan was (which Matt's email pretty much clarified) and
>> make sure that there wasn't going to be increased confusion (which a
>> comment such as Tobias mentions would do).
>> I don't think any of what has been discussed merits things being
>> out-of-tree.
> OK.
> Matt, I just tried your patches they look rather mechanical so I have little concerns. However, when testing I saw that they did break the Polly build in several ways. Is this expected? You don't happen to have a patch for Polly available, no?
> Cheers,
> Tobias

Here is the patch to fix the polly build. Most of the problems were from missing includes that RegionInfo.h used to include, and renaming of the pass to RegionInfoPass. There’s another unfortunate reinterpret_cast since Region is no longer simply a subclass of RegionNode (if there’s a better solution to this that would be nice)

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Update-for-RegionInfo-changes.patch
Type: application/octet-stream
Size: 11824 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140708/4585594e/attachment.obj>

More information about the llvm-commits mailing list