[PATCH] Move Post RA Scheduling flag bit into SchedMachineModel

Hal Finkel hfinkel at anl.gov
Tue Jul 8 13:46:45 PDT 2014

----- Original Message -----
> From: "Sanjay Patel" <spatel at rotateright.com>
> To: spatel at rotateright.com, nrotem at apple.com, atrick at apple.com, hfinkel at anl.gov
> Cc: "amara emerson" <amara.emerson at arm.com>, llvm-commits at cs.uiuc.edu
> Sent: Tuesday, July 8, 2014 3:28:18 PM
> Subject: Re: [PATCH] Move Post RA Scheduling flag bit into SchedMachineModel
> Hal - let me make sure we're on the same page. The last patch here is
> only a partial implementation of moving enablePostRAScheduler().
> I will need to add methods to all targets that use
> enablePostRAScheduler() to override the defaults for:
> getCriticalPathRCs()
> getAntiDepBreakMode()
> getOptLevelToEnablePostRAScheduler() -- this one isn't in the patch
> yet even in the TargetSubtargetInfo superclass, but it's necessary
> I can't do this in separate commits without breaking the existing
> behavior of targets that override enablePostRAScheduler(). All of
> the those targets will need to implement their custom versions of
> the 3 virtual methods to maintain the current settings.

Right, this makes sense. Please proceed with this work.

You're right, you can't separate the X86 changes because they keep the current behavior. Please ignore that comment of mine ;)

Thanks again,

> http://reviews.llvm.org/D4217

Hal Finkel
Assistant Computational Scientist
Leadership Computing Facility
Argonne National Laboratory

More information about the llvm-commits mailing list