[PATCH] MC: Let non-temporary COFF aliases be in symtab

Reid Kleckner rnk at google.com
Mon Jul 7 17:45:58 PDT 2014


Looks like upstream binutils agrees, at least for PE/COFF, which is the only COFF we care about:

Comment at: lib/MC/WinCOFFObjectWriter.cpp:554-557
@@ -550,5 +553,6 @@
                                        MCAssembler &Asm) {
   // This doesn't seem to be right. Strings referred to from the .data section
   // need symbols so they can be linked to code in the .text section right?
-  // return Asm.isSymbolLinkerVisible(SymbolData.getSymbol());
+  // return Asm.isSymbolLinkerVisible(Symbol);
Is this comment still accurate?

Comment at: test/MC/COFF/lset0.s:8
@@ -7,6 +7,3 @@
-// CHECK-NOT: not_global
-// CHECK-NOT: Llocal
-// CHECK: global
-// CHECK-NOT: not_global
-// CHECK-NOT: Llocal
+// CHECK-NOT: local
+// CHECK: A global
If you want to be really airtight, you need to CHECK-NOT before and after each CHECK or do a separate FileCheck run.


More information about the llvm-commits mailing list