[lld] [mach-o] Support -l and -syslibroot options

Shankar Easwaran shankare at codeaurora.org
Mon Jul 7 09:29:35 PDT 2014


Hi Tim,

Could you send the commit on review board ? its easier to review with that.

Thanks

Shankar Easwaran

On 7/7/2014 11:01 AM, Tim Northover wrote:
> Hi,
>
> The attached patch implements the -l and -syslibroot options for the
> Darwin lld driver. They're in the same patch because testing -l (looks
> in /usr/lib and /usr/local/lib) without being able to override the
> prefix is rather problematic.
>
> I think the implementation itself is reasonably straightforward (the
> one wrinkle is iterating through all arguments now, as opposed to just
> OPT_INPUT and OPT_l. Not *strictly* necessary yet, but adding more
> filter OPT_nnn arguments to the iterator doesn't scale and we do have
> a lot more to support in the end).
>
> The most controversial part is likely to be the testing: it adds
> crafted binary MachO inputs, which isn't ideal if they ever need
> updating (unlikely, they simply export a single, given symbol). This
> isn't exactly unique though, so hopefully won't cause any problems.
>
> OK to commit?
>
> Cheers.
>
> Tim.
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits


-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by the Linux Foundation

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140707/0683b33b/attachment.html>


More information about the llvm-commits mailing list