[llvm] r212352 - Add support for parsing the not operator in Microsoft inline assembly

Tobias Grosser tobias at grosser.es
Sat Jul 5 08:48:26 PDT 2014


On 05/07/2014 17:41, Ehsan Akhgari wrote:
> On Sat, Jul 5, 2014 at 11:35 AM, Tobias Grosser <tobias at grosser.es> wrote:
>
>> On 04/07/2014 21:13, Ehsan Akhgari wrote:
>>
>>> Author: ehsan
>>> Date: Fri Jul  4 14:13:05 2014
>>> New Revision: 212352
>>>
>>> URL: http://llvm.org/viewvc/llvm-project?rev=212352&view=rev
>>> Log:
>>> Add support for parsing the not operator in Microsoft inline assembly
>>>
>>> This fixes http://llvm.org/PR20202
>>>
>>
>> Out of interest, is there a reason you did not add a test case to
>> LLVM (e.g. into test/MC/X86/), but you only added test cases to clang
>> directly?
>
>
> No particular reason, but I would be happy to do that now.  Can you please
> suggest the right file in test/MC/X86?  Would x86-32-ms-inline-asm.s be the
> right file?

Sorry, I am not familiar enough with this area to suggest anything 
besides that a test case in LLVM seems necessary. ;-) Looking through 
git log on this directory should give you people who may now better.

Tobias




More information about the llvm-commits mailing list