[PATCH] Refactor ARM subarchitecture parsing.

Renato Golin renato.golin at linaro.org
Fri Jul 4 13:57:27 PDT 2014


Hi Gabor,

I leave the decision of adding a specific v4 to you, I don't mind much. Otherwise, LGTM.

Thanks!
--renato

================
Comment at: lib/Target/ARM/MCTargetDesc/ARMMCTargetDesc.cpp:166
@@ +165,3 @@
+    break;
+  case Triple::NoSubArch:
+    ARMArchFeature = "+v4";
----------------
I'm thinking if we need an ARMSubArch_v4 as well as the NoSubArch...

While it feels wrong to not have it, I don't think it matters much...

http://reviews.llvm.org/D4375






More information about the llvm-commits mailing list