[llvm] r211705 - Random Number Generator (llvm)

[Stephen Crane]

Alright, that makes sense to me. I'll try and rewrite the patch to store
the generator instance in LLVMContext while keeping the salt in the module?
I'm a bit concerned about the many to one mapping of modules to context,
but I'll figure out something reliable there.

- Stephen
On Jul 2, 2014 11:59 AM, "Chandler Carruth" <chandlerc at google.com> wrote:

>
> On Tue, Jul 1, 2014 at 9:50 PM, Chris Lattner <clattner at apple.com> wrote:
>
>> Any thoughts guys?  If we are unclear what the right design here is, I'd
>> prefer you to revert the patch until it is figured out.
>
>
> I'm moderately confident this isn't the right design...
>
> Specifically, I totally get why the seed and salt data needed by an RNG
> might be in the module (preferably opaquely in module-level metadata or
> something), but I don't really understand why the RN*G* would be in the
> module rather than in the pass or thing which is generating the random data
> for some purpose.
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140702/5fe6ca2a/attachment.html>