[PATCH] Improve debugging output when there is a null function pointer in the IR dump.

Philip Reames listmail at philipreames.com
Wed Jul 2 11:45:54 PDT 2014


LGTM, this seems like a strict improvement.

However, is this the best reporting we could give?  From what I can gather, null function means either an indirect call or the external function node in the callgraph.   Given the purpose of this pass, would simply skipping the null node entirely be clearer?

http://reviews.llvm.org/D4262






More information about the llvm-commits mailing list