[PATCH] Add a note to LangRef about static allocas.

[Alp Toker]

On 02/07/2014 05:48, Sean Silva wrote:
>
>
>
> On Tue, Jul 1, 2014 at 6:41 PM, Matt Arsenault 
> <Matthew.Arsenault at amd.com <mailto:Matthew.Arsenault at amd.com>> wrote:
>
>     On 07/01/2014 05:31 PM, Reid Kleckner wrote:
>
>         Sounds good to me, go for it.  I'd wordsmith it a bit.  I
>         don't think "is basically free" is important.  The important
>         thing is that the stack adjustment is folded into the function
>         prologue.
>
>     Both of these are very target specific details that don't really
>     have anything to do with the IR instruction's semantics
>
>
> I agree that it is target-specific, and that target-specific 
> information should be avoided in LangRef. However, this is a fairly 
> important distinction; for example, a frontend author should 
> definitely be aware of it.
>
> I'll wait for some more opinions.

Seems fine to add this, but perhaps drop the loud "Note" heading and 
qualify the statement with something like "a backend may fold" to 
address Matt's observation.

Alp.


>
> -- Sean Silva
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits

-- 
http://www.nuanti.com
the browser experts