[PATCH] [compiler-rt] Remove -fomit-frame-pointer from sanitizers CFLAGS

Alexander Potapenko glider at google.com
Mon Jun 30 06:23:37 PDT 2014


+kcc, samsonov

Kostya, WDYT?
I think adding -fno-omit-frame-pointers for asan_interceptors.cc is
pretty cheap and we can just do that to fix the issues with
interceptors.
But does -fomit-frame-pointers save us much provided that ASan
binaries spend little time in the runtime library? (This may be
different for TSan and MSan, however)

On Fri, Jun 27, 2014 at 9:43 PM, Kuba Břečka <kuba.brecka at gmail.com> wrote:
>> Will it help if we build the interceptors (and only them) without
>> frame pointers? This sounds like the right thing to do.
>
> Yes, this will solve the issues I'm having.
>
> I'm trying to think of other use cases where missing frame pointer would
> cause problems. How about profiling/sampling tools that take stack
> snapshots?
>
> Kuba
>



-- 
Alexander Potapenko
Software Engineer
Google Moscow




More information about the llvm-commits mailing list