Please avoid git-push style drops of 50+ commits....

Justin Holewinski justin.holewinski at gmail.com
Fri Jun 27 12:36:52 PDT 2014


It was only 25 :)

Sorry, I'll try to limit the commit frequency in the future.  For
reference, what would you recommend for spacing out larger collections of
patches?  15 minutes per 3?  30 minutes per 5?

Re: the tests, the commits that do not contain new or modified tests should
be clean-ups or structural changes where correctness is checked by existing
tests.  Thanks for looking through them!


On Fri, Jun 27, 2014 at 3:17 PM, Chandler Carruth <chandlerc at google.com>
wrote:

> This makes it *really* hard to do code review etc. They arrive on the
> email list out-of-order, and the build bots end up picking up huge chunks
> rather than having incremental coverage.
>
> I'm having a hard time getting through all of these, but a bunch of the
> commits you just pushed seem to not have tests associated with them as
> well. I will try to cite the ones missing tests, but again, this becomes
> *really* hard when you do a drop of so many commits.
>



-- 

Thanks,

Justin Holewinski
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140627/73a9a4e8/attachment.html>


More information about the llvm-commits mailing list