[llvm] r211668 - Fix another asserting method in the null streamer.

[Philip Reames]

Rafael,

Could this be addressed by overriding this method on the null streamer 
class?  Removing the check in the generic base class seems excessive.

Philip

On 06/24/2014 10:37 PM, Rafael Espindola wrote:
> Author: rafael
> Date: Wed Jun 25 00:37:58 2014
> New Revision: 211668
>
> URL: http://llvm.org/viewvc/llvm-project?rev=211668&view=rev
> Log:
> Fix another asserting method in the null streamer.
>
> Modified:
>      llvm/trunk/lib/MC/MCStreamer.cpp
>      llvm/trunk/test/DebugInfo/X86/coff_debug_info_type.ll
>
> Modified: llvm/trunk/lib/MC/MCStreamer.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/MC/MCStreamer.cpp?rev=211668&r1=211667&r2=211668&view=diff
> ==============================================================================
> --- llvm/trunk/lib/MC/MCStreamer.cpp (original)
> +++ llvm/trunk/lib/MC/MCStreamer.cpp Wed Jun 25 00:37:58 2014
> @@ -567,7 +567,6 @@ void MCStreamer::EmitWin64EHEndProlog()
>   }
>   
>   void MCStreamer::EmitCOFFSectionIndex(MCSymbol const *Symbol) {
> -  llvm_unreachable("This file format doesn't support this directive");
>   }
>   
>   void MCStreamer::EmitCOFFSecRel32(MCSymbol const *Symbol) {
>
> Modified: llvm/trunk/test/DebugInfo/X86/coff_debug_info_type.ll
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/DebugInfo/X86/coff_debug_info_type.ll?rev=211668&r1=211667&r2=211668&view=diff
> ==============================================================================
> --- llvm/trunk/test/DebugInfo/X86/coff_debug_info_type.ll (original)
> +++ llvm/trunk/test/DebugInfo/X86/coff_debug_info_type.ll Wed Jun 25 00:37:58 2014
> @@ -6,6 +6,8 @@
>   ; RUN: llc -mtriple=i686-pc-win32 -filetype=asm -O0 < %s | FileCheck -check-prefix=WIN32 %s
>   ; WIN32:    .section .debug$S,"rnd"
>   
> +; RUN: llc -mtriple=i686-pc-win32 -filetype=null -O0 < %s
> +
>   ; generated from:
>   ; clang -g -S -emit-llvm test.c -o test.ll
>   ; int main()
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits