[PATCH] MCJIT MachO debugging support

Eric Christopher echristo at gmail.com
Tue Jun 24 15:36:39 PDT 2014


One more nit since I noticed:

+    if (is64) {
+      ((MachO::section_64 *)data)->addr = Addr;
+    } else {
+      ((MachO::section *)data)->addr = Addr;
+    }

No need for the braces here.

I'm kindof dubious about this whole approach, but this matches what
the ELF stuff is doing so...

-eric

On Tue, Jun 24, 2014 at 3:04 PM, Eric Christopher <echristo at gmail.com> wrote:
> LGTM, I'll leave it up to Lang to review some of the grotty mach-o
> details I've likely forgotten :)
>
> -eric
>
> On Tue, Jun 24, 2014 at 3:02 PM, Keno Fischer
> <kfischer at college.harvard.edu> wrote:
>> One more small reformat.
>>
>> http://reviews.llvm.org/D4005
>>
>> Files:
>>   include/llvm/Object/MachO.h
>>   lib/ExecutionEngine/RuntimeDyld/RuntimeDyldMachO.cpp
>>   lib/ExecutionEngine/RuntimeDyld/RuntimeDyldMachO.h
>>   lib/Object/MachOObjectFile.cpp



More information about the llvm-commits mailing list