[PATCH] vpblend intrinsics combines as shifts intrinsics due to absence return stmt between them

Andrea Di Biagio Andrea_DiBiagio at sn.scee.net
Tue Jun 24 11:00:10 PDT 2014


Hi Robert,

Please address the two minor comments below related to the test.
Otherwise, the patch looks good to me.

Thanks!

================
Comment at: test/CodeGen/X86/pr20088.ll:3-4
@@ +2,4 @@
+
+; Function Attrs: nounwind readnone
+declare <16 x i8> @llvm.x86.sse41.pblendvb(<16 x i8>, <16 x i8>, <16 x i8>) #0
+
----------------
Remove the comment at line 3.
Remove the reference to attribute group #0.

================
Comment at: test/CodeGen/X86/pr20088.ll:6-7
@@ +5,4 @@
+
+; Function Attrs: nounwind
+define <16 x i8> @foo(<16 x i8> %x) #1 {
+; CHECK: vpblendvb
----------------
Remove the comment at line 6.
Remove the reference to attribute group #1 since it is not defined.

http://reviews.llvm.org/D4277






More information about the llvm-commits mailing list