[PATCH] ARM: Fix TPsoft for Thumb mode

Renato Golin renato.golin at linaro.org
Tue Jun 24 08:07:35 PDT 2014


With the ARMPseudoInst change, LGTM.

Thanks!
--renato

================
Comment at: lib/Target/ARM/ARMInstrInfo.td:5118
@@ +5117,3 @@
+// is defined in "ARMInstrThumb.td".
+let Predicates = [IsARM] in {
+  let isCall = 1,
----------------
Christian Pirker wrote:
> Renato Golin wrote:
> > Is this really necessary? I'd have thought that everything in here is ARM anyway, plus the instruction is different (tTPsoft instead of TPsoft).
> This pattern matches both in ARM and Thumb mode.
> This predicate makes LLVM to match the tTPsoft pattern in Thumb mode.
> I can change "PseudoInst" to "ARMPseudoInst" so that the predicate can be omitted, what you think?
> I can change "PseudoInst" to "ARMPseudoInst" so that the predicate can be omitted, what you think?

I think it's better, since the Thumb version use tPseudoInst.

http://reviews.llvm.org/D4230






More information about the llvm-commits mailing list