[PATCH] Change loop unroll and vectorizer metadata prefix to 'llvm.loop.'

Hal Finkel hfinkel at anl.gov
Tue Jun 24 03:52:28 PDT 2014


----- Original Message -----
> From: "Pekka Jääskeläinen" <pekka.jaaskelainen at tut.fi>
> To: "Mark Heffernan" <meheff at google.com>
> Cc: llvm-commits at cs.uiuc.edu, "cfe-commits" <cfe-commits at cs.uiuc.edu>
> Sent: Tuesday, June 24, 2014 5:31:56 AM
> Subject: Re: [PATCH] Change loop unroll and vectorizer metadata prefix to	'llvm.loop.'
> 
> Hi,
> 
> LGTM. One thing though: If one of the renamed metadatas was there
> already in LLVM 3.4, I think it's polite for
> out-of-tree projects (that might refer to the metadata by name) to
> have this rename mentioned in the 3.5 release notes.

Moreover, for metadata that was supported by the 3.4 release, autoupgrade support should be added. Please do this before you commit.

 -Hal

> 
> On Tue, Jun 24, 2014 at 12:30 AM, Mark Heffernan <meheff at google.com>
> wrote:
> > These patches rename the loop unrolling and loop vectorizer
> > metadata
> > such that they have a common 'llvm.loop.' prefix.  Metadata name
> > changes:
> >
> > llvm.vectorizer.* => llvm.loop.vectorizer.*
> > llvm.loopunroll.* => llvm.loop.unroll.*
> >
> > This was a suggestion from an earlier review
> > (http://reviews.llvm.org/D4090) which added the loop unrolling
> > metadata.  Two patches are attached.  One for front-end and one for
> > optimizer.
> >
> > Mark
> 
> 
> 
> --
> --PJ
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
> 

-- 
Hal Finkel
Assistant Computational Scientist
Leadership Computing Facility
Argonne National Laboratory




More information about the llvm-commits mailing list