[PATCH] [ELF] Add two new virtual functions to the `OutputELFWriter` class to control dynamic symbol table populating and DT_NEEDED tag creation

Rui Ueyama ruiu at google.com
Mon Jun 23 12:46:57 PDT 2014


LGTM with a nit.

================
Comment at: lib/ReaderWriter/ELF/Mips/MipsTargetHandler.h:70
@@ +69,3 @@
+    if (const auto *da = dyn_cast<DefinedAtom>(atom))
+      for (const auto *ref : *da) {
+        if (const auto *sla = dyn_cast<SharedLibraryAtom>(ref->target()))
----------------
nit: s/auto/Reference/

http://reviews.llvm.org/D4255






More information about the llvm-commits mailing list