[PATCH] Review for hoisting and sinking of equivalent memory instruction (Instruction Merge Pass)

[Philip Reames]

On 06/23/2014 01:02 AM, Chandler Carruth wrote:
>
> On Fri, Jun 13, 2014 at 10:04 PM, Gerolf Hoflehner 
> <ghoflehner at apple.com <mailto:ghoflehner at apple.com>> wrote:
>
>     I updated the patch yesterday, but it looks like Phabricator does
>     not notify when that happens.
>     Is this a known fundamental issue with the tool or just a
>     temporary blip?
>
>
> No, it's because Philip has a bogus email address in Phabricator, and 
> this breaks the entire system.
>
> Philip, *please* change your email in Phabricator. Let me know if 
> you're having trouble with this. Currently, it is "public @ my full 
> name .com" Note the spaces. This breaks roughly all of Phabricator's 
> email stuff. We really need Phabricator comments to go to email as 
> that remains the canonical source of review, so having a correct email 
> address is key.
I spotted this on another review and have fixed the email address. This 
is probably also the root cause of a number of other such failures 
recently.  Sorry.

Having said that, a single bad email shouldn't break notification for 
others.  Phabricator bug?

Philip

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140623/9c49c2ff/attachment.html>