[compiler-rt] Drop CRT_HAS_128BIT routines on Android

[Daniel Sanders]

It's PR20098. You're correct that the backend should be fixed but we're currently under very high load on equally important work. My opinion is that it's better to have a solution on time than the ideal solution late. If we find spare time to fix it properly then we can always revert this in favour of the better fix.

That said, I'd like Duane to change the patch. There's no need to disable this for ARM, X86, etc. Please only disable it for MIPS and add a FIXME comment explaining that it's disabled because of PR20098.

> -----Original Message-----
> From: llvm-commits-bounces at cs.uiuc.edu [mailto:llvm-commits-
> bounces at cs.uiuc.edu] On Behalf Of Joerg Sonnenberger
> Sent: 21 June 2014 02:13
> To: llvm-commits at cs.uiuc.edu
> Subject: Re: [compiler-rt] Drop CRT_HAS_128BIT routines on Android
> 
> On Fri, Jun 20, 2014 at 09:21:21PM +0000, Duane Sand wrote:
> > The attached patch is an urgent workaround in builds of the
> > compiler-rt component of Android.  The recently-added CRT_HAS_128BIT
> > routines make use of host compiler support of 128-bit ints via the
> > mode(TI) compiler extension.  The mips64 llvm compiler back end
> > crashes on uses of that extension.
> 
> Frankly, that should be fixed in the backend. Do you have an open PR for
> this?
> 
> Joerg
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits