[PATCH 1/1] R600: Add udivrem test

[Matt Arsenault]

On Jun 22, 2014, at 12:42 PM, Jan Vesely <jan.vesely at rutgers.edu> wrote:

> Signed-off-by: Jan Vesely <jan.vesely at rutgers.edu>
> ---
> test/CodeGen/R600/udivrem.ll | 162 +++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 162 insertions(+)
> create mode 100644 test/CodeGen/R600/udivrem.ll
> 
> diff --git a/test/CodeGen/R600/udivrem.ll b/test/CodeGen/R600/udivrem.ll
> new file mode 100644
> index 0000000..268000a
> --- /dev/null
> +++ b/test/CodeGen/R600/udivrem.ll
> @@ -0,0 +1,162 @@
> +;RUN: llc < %s -march=r600 -mcpu=SI -verify-machineinstrs| FileCheck --check-prefix=SI --check-prefix=FUNC %s
> +;RUN: llc < %s -march=r600 -mcpu=redwood | FileCheck --check-prefix=EG --check-prefix=FUNC %s

2 nits:
Can you move the < %s to the end of the line? It makes it easier to copy-paste the run line when the test fails.
Also, space between the ; and the start of the comments.

Another test (that doesn’t need to check anything) that might be useful is <4 x i32> since it’s the other legal int vector type

Besides those, LGTM

> +
> +;FUNC-LABEL: @test_udivrem
> +;EG: RECIP_UINT
> +;EG-DAG: MULHI
> +;EG-DAG: MULLO_INT
> +;EG-DAG: SUB_INT
> +;EG: CNDE_INT
> +;EG: MULHI
> +;EG-DAG: ADD_INT
> +;EG-DAG: SUB_INT
> +;EG: CNDE_INT
> +;EG: MULHI
> +;EG: MULLO_INT
> +;EG: SUB_INT
> +;EG-DAG: SETGE_UINT
> +;EG-DAG: SETGE_UINT
> +;EG: AND_INT
> +;EG-DAG: ADD_INT
> +;EG-DAG: SUB_INT
> +;EG-DAG: CNDE_INT
> +;EG-DAG: CNDE_INT
> +;EG-DAG: ADD_INT
> +;EG-DAG: SUB_INT
> +;EG-DAG: CNDE_INT
> +;EG-DAG: CNDE_INT
> +
> +;SI: V_RCP_IFLAG_F32_e32 [[RCP:v[0-9]+]]
> +;SI-DAG: V_MUL_HI_U32 [[RCP_HI:v[0-9]+]], [[RCP]]
> +;SI-DAG: V_MUL_LO_I32 [[RCP_LO:v[0-9]+]], [[RCP]]
> +;SI-DAG: V_SUB_I32_e32 [[NEG_RCP_LO:v[0-9]+]], 0, [[RCP_LO]]
> +;SI: V_CNDMASK_B32_e64
> +;SI: V_MUL_HI_U32 [[E:v[0-9]+]], {{v[0-9]+}}, [[RCP]]
> +;SI-DAG: V_ADD_I32_e32 [[RCP_A_E:v[0-9]+]], [[E]], [[RCP]]
> +;SI-DAG: V_SUBREV_I32_e32 [[RCP_S_E:v[0-9]+]], [[E]], [[RCP]]
> +;SI: V_CNDMASK_B32_e64
> +;SI: V_MUL_HI_U32 [[Quotient:v[0-9]+]]
> +;SI: V_MUL_LO_I32 [[Num_S_Remainder:v[0-9]+]]
> +;SI-DAG: V_SUB_I32_e32 [[Remainder:v[0-9]+]], {{[vs][0-9]+}}, [[Num_S_Remainder]]
> +;SI-DAG: V_CNDMASK_B32_e64
> +;SI-DAG: V_CNDMASK_B32_e64
> +;SI: V_AND_B32_e32 [[Tmp1:v[0-9]+]]
> +;SI-DAG: V_ADD_I32_e32 [[Quotient_A_One:v[0-9]+]], 1, [[Quotient]]
> +;SI-DAG: V_SUBREV_I32_e32 [[Quotient_S_One:v[0-9]+]],
> +;SI-DAG: V_CNDMASK_B32_e64
> +;SI-DAG: V_CNDMASK_B32_e64
> +;SI-DAG: V_ADD_I32_e32 [[Remainder_A_Den:v[0-9]+]],
> +;SI-DAG: V_SUBREV_I32_e32 [[Remainder_S_Den:v[0-9]+]],
> +;SI-DAG: V_CNDMASK_B32_e64
> +;SI-DAG: V_CNDMASK_B32_e64
> +;SI: S_ENDPGM
> +define void @test_udivrem(i32 addrspace(1)* %out, i32 %x, i32 %y) {
> +  %result0 = udiv i32 %x, %y
> +  store i32 %result0, i32 addrspace(1)* %out
> +  %result1 = urem i32 %x, %y
> +  store i32 %result1, i32 addrspace(1)* %out
> +  ret void
> +}
> +
> +;FUNC-LABEL: @test_udivrem_v2
> +;EG-DAG: RECIP_UINT
> +;EG-DAG: MULHI
> +;EG-DAG: MULLO_INT
> +;EG-DAG: SUB_INT
> +;EG-DAG: CNDE_INT
> +;EG-DAG: MULHI
> +;EG-DAG: ADD_INT
> +;EG-DAG: SUB_INT
> +;EG-DAG: CNDE_INT
> +;EG-DAG: MULHI
> +;EG-DAG: MULLO_INT
> +;EG-DAG: SUB_INT
> +;EG-DAG: SETGE_UINT
> +;EG-DAG: SETGE_UINT
> +;EG-DAG: AND_INT
> +;EG-DAG: ADD_INT
> +;EG-DAG: SUB_INT
> +;EG-DAG: CNDE_INT
> +;EG-DAG: CNDE_INT
> +;EG-DAG: ADD_INT
> +;EG-DAG: SUB_INT
> +;EG-DAG: CNDE_INT
> +;EG-DAG: CNDE_INT
> +;EG-DAG: RECIP_UINT
> +;EG-DAG: MULHI
> +;EG-DAG: MULLO_INT
> +;EG-DAG: SUB_INT
> +;EG-DAG: CNDE_INT
> +;EG-DAG: MULHI
> +;EG-DAG: ADD_INT
> +;EG-DAG: SUB_INT
> +;EG-DAG: CNDE_INT
> +;EG-DAG: MULHI
> +;EG-DAG: MULLO_INT
> +;EG-DAG: SUB_INT
> +;EG-DAG: SETGE_UINT
> +;EG-DAG: SETGE_UINT
> +;EG-DAG: AND_INT
> +;EG-DAG: ADD_INT
> +;EG-DAG: SUB_INT
> +;EG-DAG: CNDE_INT
> +;EG-DAG: CNDE_INT
> +;EG-DAG: ADD_INT
> +;EG-DAG: SUB_INT
> +;EG-DAG: CNDE_INT
> +;EG-DAG: CNDE_INT
> +
> +;SI-DAG: V_RCP_IFLAG_F32_e32 [[FIRST_RCP:v[0-9]+]]
> +;SI-DAG: V_MUL_HI_U32 [[FIRST_RCP_HI:v[0-9]+]], [[FIRST_RCP]]
> +;SI-DAG: V_MUL_LO_I32 [[FIRST_RCP_LO:v[0-9]+]], [[FIRST_RCP]]
> +;SI-DAG: V_SUB_I32_e32 [[FIRST_NEG_RCP_LO:v[0-9]+]], 0, [[FIRST_RCP_LO]]
> +;SI-DAG: V_CNDMASK_B32_e64
> +;SI-DAG: V_MUL_HI_U32 [[FIRST_E:v[0-9]+]], {{v[0-9]+}}, [[FIRST_RCP]]
> +;SI-DAG: V_ADD_I32_e32 [[FIRST_RCP_A_E:v[0-9]+]], [[FIRST_E]], [[FIRST_RCP]]
> +;SI-DAG: V_SUBREV_I32_e32 [[FIRST_RCP_S_E:v[0-9]+]], [[FIRST_E]], [[FIRST_RCP]]
> +;SI-DAG: V_CNDMASK_B32_e64
> +;SI-DAG: V_MUL_HI_U32 [[FIRST_Quotient:v[0-9]+]]
> +;SI-DAG: V_MUL_LO_I32 [[FIRST_Num_S_Remainder:v[0-9]+]]
> +;SI-DAG: V_SUB_I32_e32 [[FIRST_Remainder:v[0-9]+]], {{[vs][0-9]+}}, [[FIRST_Num_S_Remainder]]
> +;SI-DAG: V_CNDMASK_B32_e64
> +;SI-DAG: V_CNDMASK_B32_e64
> +;SI-DAG: V_AND_B32_e32 [[FIRST_Tmp1:v[0-9]+]]
> +;SI-DAG: V_ADD_I32_e32 [[FIRST_Quotient_A_One:v[0-9]+]], {{.*}}, [[FIRST_Quotient]]
> +;SI-DAG: V_SUBREV_I32_e32 [[FIRST_Quotient_S_One:v[0-9]+]],
> +;SI-DAG: V_CNDMASK_B32_e64
> +;SI-DAG: V_CNDMASK_B32_e64
> +;SI-DAG: V_ADD_I32_e32 [[FIRST_Remainder_A_Den:v[0-9]+]],
> +;SI-DAG: V_SUBREV_I32_e32 [[FIRST_Remainder_S_Den:v[0-9]+]],
> +;SI-DAG: V_CNDMASK_B32_e64
> +;SI-DAG: V_CNDMASK_B32_e64
> +;SI-DAG: V_RCP_IFLAG_F32_e32 [[SECOND_RCP:v[0-9]+]]
> +;SI-DAG: V_MUL_HI_U32 [[SECOND_RCP_HI:v[0-9]+]], [[SECOND_RCP]]
> +;SI-DAG: V_MUL_LO_I32 [[SECOND_RCP_LO:v[0-9]+]], [[SECOND_RCP]]
> +;SI-DAG: V_SUB_I32_e32 [[SECOND_NEG_RCP_LO:v[0-9]+]], 0, [[SECOND_RCP_LO]]
> +;SI-DAG: V_CNDMASK_B32_e64
> +;SI-DAG: V_MUL_HI_U32 [[SECOND_E:v[0-9]+]], {{v[0-9]+}}, [[SECOND_RCP]]
> +;SI-DAG: V_ADD_I32_e32 [[SECOND_RCP_A_E:v[0-9]+]], [[SECOND_E]], [[SECOND_RCP]]
> +;SI-DAG: V_SUBREV_I32_e32 [[SECOND_RCP_S_E:v[0-9]+]], [[SECOND_E]], [[SECOND_RCP]]
> +;SI-DAG: V_CNDMASK_B32_e64
> +;SI-DAG: V_MUL_HI_U32 [[SECOND_Quotient:v[0-9]+]]
> +;SI-DAG: V_MUL_LO_I32 [[SECOND_Num_S_Remainder:v[0-9]+]]
> +;SI-DAG: V_SUB_I32_e32 [[SECOND_Remainder:v[0-9]+]], {{[vs][0-9]+}}, [[SECOND_Num_S_Remainder]]
> +;SI-DAG: V_CNDMASK_B32_e64
> +;SI-DAG: V_CNDMASK_B32_e64
> +;SI-DAG: V_AND_B32_e32 [[SECOND_Tmp1:v[0-9]+]]
> +;SI-DAG: V_ADD_I32_e32 [[SECOND_Quotient_A_One:v[0-9]+]], {{.*}}, [[SECOND_Quotient]]
> +;SI-DAG: V_SUBREV_I32_e32 [[SECOND_Quotient_S_One:v[0-9]+]],
> +;SI-DAG: V_CNDMASK_B32_e64
> +;SI-DAG: V_CNDMASK_B32_e64
> +;SI-DAG: V_ADD_I32_e32 [[SECOND_Remainder_A_Den:v[0-9]+]],
> +;SI-DAG: V_SUBREV_I32_e32 [[SECOND_Remainder_S_Den:v[0-9]+]],
> +;SI-DAG: V_CNDMASK_B32_e64
> +;SI-DAG: V_CNDMASK_B32_e64
> +;SI: S_ENDPGM
> +define void @test_udivrem_v2(<2 x i32> addrspace(1)* %out, <2 x i32> %x, <2 x i32> %y) {
> +  %result0 = udiv <2 x i32> %x, %y
> +  store <2 x i32> %result0, <2 x i32> addrspace(1)* %out
> +  %result1 = urem <2 x i32> %x, %y
> +  store <2 x i32> %result1, <2 x i32> addrspace(1)* %out
> +  ret void
> +}
> -- 
> 1.9.3
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits