[PATCH] [AArch64] Implement pseudo LDR <reg>, =<literal/label>

David Peixotto dpeixott at codeaurora.org
Fri Jun 20 11:30:44 PDT 2014


Minor cleanup, otherwise LGTM.

As a suggestion for the future I think it would be better to start a new differential revision for each patch. Also, if you add "Differential Revison: <url>" to the commit message it will close it automatically on commit.

================
Comment at: lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp:3031
@@ +3030,3 @@
+            Operands[1]->getReg());
+      uint64_t Imm = (dyn_cast<MCConstantExpr>(SubExprVal))->getValue();
+      uint32_t ShiftAmt = 0, MaxShiftAmt = IsXReg ? 48 : 16;
----------------
use cast<> instead of dyn_cast<> when not checking the return value for null.

http://reviews.llvm.org/D4163






More information about the llvm-commits mailing list