[PATCH] [lld] Rename variable to avoid system header conflict

Shankar Easwaran shankare at codeaurora.org
Fri Jun 20 09:50:34 PDT 2014


LGTM.

On 6/20/2014 11:40 AM, Tim Northover wrote:
> On 20 June 2014 16:48, Shankar Easwaran <shankare at codeaurora.org> wrote:
>> I think the right place to put this is in PECOFFLinkingContext and have a
>> virtual function getPageSize() similar to ELF.
> Sounds like a good idea. I've attached another diff with this
> solution. How does it look?
>
> I considered doing the same thing for the next variable SECTOR_SIZE,
> but it seemed rather more intrusive so I decided against it in the
> end. It's not a ridiculous idea for someone with a more active
> knowledge of the PE/COFF design and conventions though (so they know
> where to make _ctx a member variable and where to pass it in).
>
> Cheers.
>
> Tim.


-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by the Linux Foundation




More information about the llvm-commits mailing list