[llvm] r211305 - Remove an incorrect fixme.

Rafael Espindola rafael.espindola at gmail.com
Thu Jun 19 12:45:26 PDT 2014


Author: rafael
Date: Thu Jun 19 14:45:25 2014
New Revision: 211305

URL: http://llvm.org/viewvc/llvm-project?rev=211305&view=rev
Log:
Remove an incorrect fixme.

dynamic-no-pic is just another output type. If gnu ld gets support for MachO,
it should also add something like LDPO_DYN_NO_PIC to the plugin interface.

Modified:
    llvm/trunk/tools/gold/gold-plugin.cpp

Modified: llvm/trunk/tools/gold/gold-plugin.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/gold/gold-plugin.cpp?rev=211305&r1=211304&r2=211305&view=diff
==============================================================================
--- llvm/trunk/tools/gold/gold-plugin.cpp (original)
+++ llvm/trunk/tools/gold/gold-plugin.cpp Thu Jun 19 14:45:25 2014
@@ -169,8 +169,6 @@ ld_plugin_status onload(ld_plugin_tv *tv
                        tv->tv_u.tv_val);
             return LDPS_ERR;
         }
-        // TODO: add an option to disable PIC.
-        //output_type = LTO_CODEGEN_PIC_MODEL_DYNAMIC_NO_PIC;
         break;
       case LDPT_OPTION:
         options::process_plugin_option(tv->tv_u.tv_string);





More information about the llvm-commits mailing list