[PATCH] PR10140 - StringPool's PooledStringPtr has non-const operator== causing bad OR-result

David Blaikie dblaikie at gmail.com
Wed Jun 18 17:19:35 PDT 2014


Oh, you don't need to create a separate class for the tests, just using "TEST(Grouping, Testname)" will work fine.

Please commit after you've made that change (removed "PooledStringPtrTest" class and changed from TEST_F to TEST macros).

Thanks for the work. For future reference I was suggesting that "adding explicit" could be done as a separate step, but it's fine together too. Thanks again.

http://reviews.llvm.org/D4194






More information about the llvm-commits mailing list