[LNT] Parse --version correctly from CMake builds

[Tilmann Scheller]

Hi,

 

actually there's a patch pending for review which improves the version info for CMake builds: http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20140526/219022.html

 

Seems like it adds the repository to the version information.

 

Regards,

 

Tilmann

 

 

From: llvm-commits-bounces at cs.uiuc.edu [mailto:llvm-commits-bounces at cs.uiuc.edu] On Behalf Of James Molloy
Sent: Wednesday, June 18, 2014 9:50 AM
To: Chris Matthews; David Blaikie
Cc: llvm-commits at cs.uiuc.edu; Yi Kong
Subject: RE: [LNT] Parse --version correctly from CMake builds

 

Hi,

 

Committed as r211148. Agreed that we should change CMake too, I was just a bit worried about other consumers breaking!

 

Cheers,

 

James

 

From: Chris Matthews [mailto:chris.matthews at apple.com] 
Sent: 17 June 2014 19:44
To: David Blaikie
Cc: James Molloy; llvm-commits at cs.uiuc.edu; Yi Kong
Subject: Re: [LNT] Parse --version correctly from CMake builds

 

I do think this needs to be fixed in the build system, LNT is not the only consumer of version information.   It would also be good for LNT to support older cmake builds, so lets add this patch as well.

 

Patch LGTM.

 

On Jun 17, 2014, at 10:37 AM, David Blaikie <dblaikie at gmail.com> wrote:

 

Worth fixing the cmake build instead? Having branch/revision number in
there is rather nice to have.

(but yeah, if this is the substantially easier fix, I can't complain
about it making broken things not so broken)

On Tue, Jun 17, 2014 at 5:21 AM, James Molloy < <mailto:james.molloy at arm.com> james.molloy at arm.com> wrote:

Hi Yi, Chris,



LNT currently fails to parse clang’s –version string correctly for CMake
builds. CMake builds do not emit the branch name, they only emit the
revision. Currently LNT thinks the revision number is the branch name, which
also means it fails to infer the run_order correctly for submission.



The attached simple patch fixes this.



OK to commit?



Cheers,



James


_______________________________________________
llvm-commits mailing list
llvm-commits at cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits

 


-- IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

ARM Limited, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, Registered in England & Wales, Company No: 2557590
ARM Holdings plc, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, Registered in England & Wales, Company No: 2548782

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140618/cb9191ae/attachment.html>