I responded to all the comments via Phabricator over an hour ago, but Phabricator never sent out the corresponding email :-( I've verified that others can see my comment at http://reviews.llvm.org/D4090 so please look there for my responses and latest patch. Mark http://reviews.llvm.org/D4090