[llvm] r211003 - Fix copy paste error

Matt Arsenault arsenm2 at gmail.com
Sun Jun 15 15:56:45 PDT 2014


On Jun 15, 2014, at 3:46 PM, David Blaikie <dblaikie at gmail.com> wrote:

> Test coverage?
> 

I’m not really sure how this would break anything. It seems everywhere that uses this also checks if ConstantFP is legal, which is already true for both of these cases.


> On Sun, Jun 15, 2014 at 2:22 PM, Matt Arsenault
> <Matthew.Arsenault at amd.com> wrote:
>> Author: arsenm
>> Date: Sun Jun 15 16:22:52 2014
>> New Revision: 211003
>> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=211003&view=rev
>> Log:
>> Fix copy paste error
>> 
>> Modified:
>>    llvm/trunk/lib/Target/R600/AMDGPUISelLowering.cpp
>> 
>> Modified: llvm/trunk/lib/Target/R600/AMDGPUISelLowering.cpp
>> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/R600/AMDGPUISelLowering.cpp?rev=211003&r1=211002&r2=211003&view=diff
>> ==============================================================================
>> --- llvm/trunk/lib/Target/R600/AMDGPUISelLowering.cpp (original)
>> +++ llvm/trunk/lib/Target/R600/AMDGPUISelLowering.cpp Sun Jun 15 16:22:52 2014
>> @@ -354,7 +354,7 @@ MVT AMDGPUTargetLowering::getVectorIdxTy
>> // FIXME: Why are we reporting vectors of FP immediates as legal?
>> bool AMDGPUTargetLowering::isFPImmLegal(const APFloat &Imm, EVT VT) const {
>>   EVT ScalarVT = VT.getScalarType();
>> -  return (ScalarVT == MVT::f32 || MVT::f64);
>> +  return (ScalarVT == MVT::f32 || ScalarVT == MVT::f64);
>> }
>> 
>> // We don't want to shrink f64 / f32 constants.
>> 
>> 
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits





More information about the llvm-commits mailing list