[PATCH] ARMEB: Fix trunc store for vector types

James Molloy james.molloy at arm.com
Sun Jun 15 12:48:48 PDT 2014


Hi Christian,

This looks good to me, I have only one comment that should be trivial to address before commit.

Cheers,

James

================
Comment at: test/CodeGen/ARM/big-endian-neon-trunc-store.ll:17
@@ +16,3 @@
+; CHECK-LABEL: vector_trunc_store_4i32_to_4i8:
+; CHECK:       vmovn.i32 [[REG:d[0-9]+]]
+; CHECK:       vrev16.8  [[REG]], [[REG]]
----------------
I just tried your patch, and this test case is producing another REV just above this line. Is that expected? If so, please add it as a CHECK line so that it is obvioiusly expected behaviour.

http://reviews.llvm.org/D4135






More information about the llvm-commits mailing list