[PATCH] Change the LLVM global lock to use RAII semantics

Zachary Turner zturner at google.com
Fri Jun 13 16:55:58 PDT 2014


Gah, again.  I need to start using clang-format.  Thanks for catching this.


On Fri, Jun 13, 2014 at 4:53 PM, David Majnemer <david.majnemer at gmail.com>
wrote:

> ================
> Comment at: include/llvm/Support/Threading.h:21
> @@ +20,3 @@
> +  /// llvm_get_global_lock - returns the llvm global lock object.
> +  sys::Mutex& llvm_get_global_lock();
> +
> ----------------
> The `&` should bind to the function name, not the return type.
>
> http://reviews.llvm.org/D4142
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140613/6ca7b888/attachment.html>


More information about the llvm-commits mailing list