[llvm] r210641 - Create macro INITIALIZE_TM_PASS.

Jiangning Liu liujiangning1 at gmail.com
Fri Jun 13 16:38:21 PDT 2014

Hi Chandler,

2014-06-14 0:11 GMT+08:00 Chandler Carruth <chandlerc at google.com>:

> On Fri, Jun 13, 2014 at 5:03 PM, Jiangning Liu <liujiangning1 at gmail.com>
> wrote:
>> Hi Chandler,
>> Attached patch is fix this issue. OK to commit?
> Mostly...
> I don't really understand the changes in
> test/CodeGen/ARM/global-merge-1.ll though. You seem to be removing a bunch
> of tests (perhaps in addition to merging in the test from
> test/Transforms/GlobalMerge/ARM/...) which doesn't make sense to me.
> Otherwise everything seems good.
I kept the original version of test/CodeGen/ARM/global-merge-1.ll.

I committed as r210951 and r210952. r210952 is to completely remove folder

>> BTW, should we also have a regression test to check the libraries'
>> dependency?
> Not sure of an easy way to do this, but maybe its worthwhile.

I really didn't realize this small change of add macro INITIALIZE_TM_PASS
raised such a lot of nervous. Sorry for any inconvenience caused! It seems
at least Qunentin and Rafael also thought we could make this kind of change
at first look. Hopefully I'm the last one making this kind of mistake.

So I think it's worthwhile to add this kind of regression test. At least it
can enhance llvm infrastructure robustness and clear layers on libxxx.a/so

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140614/edfd3549/attachment.html>

More information about the llvm-commits mailing list