[polly] Little refactoring

Tobias Grosser tobias at grosser.es
Fri Jun 13 09:40:21 PDT 2014

On 13/06/2014 18:08, Johannes Doerfert wrote:
>>> On 06/13/2014 01:27 AM, Johannes Doerfert wrote:
>>>> Refactoring:
>>>> -          Refactored reoccurring if cascade
>>> LGTM.
> One more to commit.
>>>> -          C++11 iterators & range loops.
>>> I'm not sure what others think, but I don't like range loops that use
> auto for the element type. It is a MemoryAccess, why not call it that way
> ;-).
> I can do both [As long as I can use range loops ;)]. Is there a llvm
> guideline? If not let's define one for us.

I would use the explicit type, except if this type is obviously 
redundant or overly complex.

>>> Apart from that, LGTM.
> Once the above is cleared, one more to commit.

Feel free to commit. (Just reply with the commit id, such that it 
becomes clear this thread is closed)


More information about the llvm-commits mailing list