[polly] Little refactoring

Andreas Simbuerger simbuerg at googlemail.com
Fri Jun 13 01:39:59 PDT 2014


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1



On 06/13/2014 01:27 AM, Johannes Doerfert wrote:
> Refactoring:
> 
> -          Refactored reoccurring if cascade

LGTM.

> 
> -          C++11 iterators & range loops.

I'm not sure what others think, but I don't like range loops that use
auto for the element type. It is a MemoryAccess, why not call it that
way ;-).

Apart from that, LGTM.

Cheers,
Andreas
> 
> 
> 
> Any thoughts?
> 
> 
> 
> --
> 
> 
> 
> Johannes Doerfert
> 
> Employee of Qualcomm Innovation Center, Inc.
> 
> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
> hosted by The Linux Foundation
> 
> 
> 
> 
> 
> 
> _______________________________________________ llvm-commits
> mailing list llvm-commits at cs.uiuc.edu 
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
> 

- -- 
Andreas Simb├╝rger
University of Passau - Programming Group
http://www.infosun.fim.uni-passau.de/cl/staff/simbuerger/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (GNU/Linux)

iQEcBAEBAgAGBQJTmrjfAAoJELS7a/6Ti2HYU/MH/jIEtIHIqMMwQixkTt5ZNyZc
/5Ht7ratdo6h0qoSVHMAKAKYmtJ/BGMQv7a2Q+u21F/TPAUq0SemAhkZTFAbEDl/
hjRNlgwfkZtRoD8Gv2qzVH+z35L1lNNSSXzGaLWj3cIslWP9V0TmvqniHNn5Sv/D
LrBW7cD8K01fSdegrR1PvJCdV+ozju/CJnw+P3WWgxtpPKL5G7alCy9QDqsmhqNT
I5K0Setexg3t5gVYRGd3MU9r099wQ3Y+vb3JwNezpezusLTLshZMAEZkQfY5XRNI
mJVLcir3hU24xpsIJ5qpn43XdckwV1FET4Zrfem/El+Xuj0F0cfvhLOBDTNe1AY=
=IIbF
-----END PGP SIGNATURE-----



More information about the llvm-commits mailing list