[llvm] r210734 - Fix verifier for GlobalAliases to avoid recursing into global initializers.

Bob Wilson bob.wilson at apple.com
Thu Jun 12 14:46:10 PDT 2014


On Jun 12, 2014, at 5:04 AM, Rafael EspĂ­ndola <rafael.espindola at gmail.com> wrote:

>> 
>> Modified: llvm/trunk/test/Verifier/alias.ll
>> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Verifier/alias.ll?rev=210734&r1=210733&r2=210734&view=diff
>> ==============================================================================
>> --- llvm/trunk/test/Verifier/alias.ll (original)
>> +++ llvm/trunk/test/Verifier/alias.ll Wed Jun 11 20:46:54 2014
>> @@ -11,6 +11,10 @@ declare void @f()
>> ; CHECK: Alias must point to a definition
>> ; CHECK-NEXT: @ga
>> 
>> +; References to a global declaration from an initializer are OK.
>> + at gptr = global i32* @g
>> + at gptr_a = alias i32** @gptr
>> +; CHECK-NOT: Alias must point to a definition
>> 
> 
> Thanks. A better test would be to put this in a testcase that is not
> expected to fail, like test/Feature/aliases.ll.

OK. I moved the test in r210833.



More information about the llvm-commits mailing list