Optimize load from aggregate stores

[Philip Reames]

On 06/12/2014 12:28 AM, Owen Anderson wrote:
>
> On Jun 11, 2014, at 11:29 PM, deadal nix <deadalnix at gmail.com 
> <mailto:deadalnix at gmail.com>> wrote:
>
>> It is gonna improve the situation quite a lot for all frontend that 
>> use aggregate loads (arguably, that is a bad practice, but that no 
>> reason to stab people in the back when they do it anyway).
>
> I'm not sure I agree with that statement.  If we don't think they 
> should be used, not optimizing them is a good way to discourage that. 
>  More generally, I'm concerned about how we will ever get good test 
> coverage of this code path, since we don't have any extant front ends 
> that hit it.
I'm joining this discussion late, but a) why are aggregate loads bad 
practice?  Loading something like a small struct from memory with a 
single load seems reasonable.  b) There are frontends that are not in 
tree.  The fact that Deadal submitted the patch is a good hint that 
*someone* cares.  c) Is there a phabricator link for this change?  I 
can't find the original thread.

Philip
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140612/8bc03169/attachment.html>