[Patch] Enable value forwarding for loads from calloc without intervening store

Duncan P. N. Exon Smith dexonsmith at apple.com
Thu Jun 12 08:16:17 PDT 2014

> On 2014 Jun 11, at 10:15, Philip Reames <listmail at philipreames.com> wrote:
> Attached.


> http://reviews.llvm.org/D3931
> Philip
> <calloc-load-forward.diff>

LGTM.  Do you need me to commit it for you?

BTW, I noticed another strange whitespace thing -- if I'm committing it,
I'll just fix this myself, but if you're committing it please run

+      ValuesPerBlock.push_back(AvailableValueInBlock::get(DepBB,
+                                             Constant::getNullValue(LI->getType())));

This indentation is strange (and violates 80-columns).  clang-format's
opinion is this:

          DepBB, Constant::getNullValue(LI->getType())));

More information about the llvm-commits mailing list