[llvm] r210516 - Delete X86JITInfo in the subtarget destructor.

David Blaikie dblaikie at gmail.com
Tue Jun 10 18:02:17 PDT 2014


On Tue, Jun 10, 2014 at 5:54 PM, Eric Christopher <echristo at gmail.com> wrote:
> On Tue, Jun 10, 2014 at 11:36 AM, Eric Christopher <echristo at gmail.com> wrote:
>> On Tue, Jun 10, 2014 at 8:06 AM, David Blaikie <dblaikie at gmail.com> wrote:
>>> On Tue, Jun 10, 2014 at 1:03 AM, Eric Christopher <echristo at gmail.com> wrote:
>>>> Author: echristo
>>>> Date: Tue Jun 10 03:03:42 2014
>>>> New Revision: 210516
>>>>
>>>> URL: http://llvm.org/viewvc/llvm-project?rev=210516&view=rev
>>>> Log:
>>>> Delete X86JITInfo in the subtarget destructor.
>>>>
>>>> Modified:
>>>>     llvm/trunk/lib/Target/X86/X86Subtarget.cpp
>>>>
>>>> Modified: llvm/trunk/lib/Target/X86/X86Subtarget.cpp
>>>> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86Subtarget.cpp?rev=210516&r1=210515&r2=210516&view=diff
>>>> ==============================================================================
>>>> --- llvm/trunk/lib/Target/X86/X86Subtarget.cpp (original)
>>>> +++ llvm/trunk/lib/Target/X86/X86Subtarget.cpp Tue Jun 10 03:03:42 2014
>>>> @@ -363,6 +363,7 @@ X86Subtarget::~X86Subtarget() {
>>>>    delete TLInfo;
>>>>    delete InstrInfo;
>>>>    delete FrameLowering;
>>>> +  delete JITInfo;
>>>
>>> An opportunity for some std::unique_ptrs?
>>>
>>
>> Mmm.. probably. :)
>>
>
> Done, along with the other cleanups you suggested as far as
> initializer lists. Thanks!

Looks great, thanks!

(210614 for anyone playing at home/in the future)

- David



More information about the llvm-commits mailing list