[PATCH] Remove support for enabling / disabling multi-threading at runtime.

Zachary Turner zturner at google.com
Tue Jun 10 12:46:26 PDT 2014

Maybe a bug in Phabricator, but for some reason email notifications for
this particular issue are no longer being sent out.  So I'm responding here
since changes a new revision has been uploaded:

Most recent summary:
1) All major review issues addressed
2) rnk@ spoke to someone from Apple who said their biggest concern is
whether it will have any impact on single-threaded compilation performance.
3) Ran tests on MacOSX by compiling sqlite3.c with / without the patch, and
saw no noticeable impact on performance, which hopefully satisfies the
concern raised in #2
4) Change was discussed on LLVMDev prior to initial upload to Phabricator,
so some support has been built for this already.  If anyone feels like more
is necessary before committing, please speak up.

On Mon, Jun 9, 2014 at 4:27 PM, Zachary Turner <zturner at google.com> wrote:

> Address review comments.
> http://reviews.llvm.org/D4076
> Files:
>   include/llvm-c/Core.h
>   include/llvm/Support/ManagedStatic.h
>   include/llvm/Support/Threading.h
>   lib/IR/Core.cpp
>   lib/Support/ErrorHandling.cpp
>   lib/Support/ManagedStatic.cpp
>   lib/Support/Threading.cpp
>   lib/Support/Timer.cpp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140610/ecfae15b/attachment.html>

More information about the llvm-commits mailing list