[PATCH][X86] Add target combine rules for horizontal add/sub.

Andrea Di Biagio andrea.dibiagio at gmail.com
Tue Jun 10 10:15:40 PDT 2014

On Tue, Jun 10, 2014 at 6:07 PM, Nadav Rotem <nrotem at apple.com> wrote:
>> On Jun 10, 2014, at 9:57 AM, Andrea Di Biagio <andrea.dibiagio at gmail.com> wrote:
>> Hi Nadav,
>> I just committed revision 210545 to fix a bug introduced by my
>> original patch committed at revision 210477.
>> I spotted this bug when running some extra tests to see if the
>> algorithm was able to identify all the interesting cases.
>> As described in the commit log message for revision 210545, the old
>> algorithm wrongly matched the 256-bit versions of horizontal add/sub
>> (on AVX and AVX2).
>> Sorry for the mistake.
>> Since the change was small, I decided to commit it immediately. I hope
>> it was ok to do it. If not, then please let me know so that I revert
>> it.
> Andrea,
> I am very happy about the good work that you are doing on the X86 backend. You don’t need to request pre-commit approval for every change. I promise to review the changes after they land. :)

Thanks Nadav!
I just wanted to make sure that I was doing the correct thing :-)


More information about the llvm-commits mailing list