[PATCH] CodeGen: refactor DwarfException

Tim Northover t.p.northover at gmail.com
Tue Jun 10 10:04:27 PDT 2014

Hi Saleem,

This looks like a very good idea. Just one comment on something that could be tidied at the same time...

Comment at: lib/CodeGen/AsmPrinter/EHStreamer.cpp:33
@@ +32,3 @@
+/// How many leading type ids two landing pads have in common.
+unsigned EHStreamer::SharedTypeIds(const LandingPadInfo *L,
+                                   const LandingPadInfo *R) {
It would be a shame to do this mass move and not take the opportunity to rename this "sharedTypeIds" to match the LLVM style guide.

Similarly for the other functions here. Most of them seem fairly localised.


More information about the llvm-commits mailing list