[PATCH] Fix a bug in the Thumb1 ARM Load/Store optimizer which resulted in the base register reset instruction being incorrectly placed.

Moritz Roth moritz.roth at arm.com
Tue Jun 10 08:53:32 PDT 2014

>>! In D4084#7, @rengolin wrote:
> Hi Morizt,
> Apart from the comment, LGTM.
> --renato

Hi Renato,

this was also a bug (which resulted in this issue happening in a few extra cases as far as I can tell) - we do
  Opcode = getLoadStoreMultipleOpcode(Opcode, Mode);
a few lines before this check so Opcode can never be tLDRi (it would have been changed to tLDMIA).

I don't have commit access by the way, so someone else will have to commit this on my behalf.



More information about the llvm-commits mailing list