[PATCH] Make compiler-rt tests work with relocatable SDKs on OS X

Alexander Potapenko glider at google.com
Tue Jun 10 08:32:35 PDT 2014

Looks mostly good (see the comments). I'm not sure this doesn't break on 10.8, but let's see if any problems appear.

Comment at: compiler-rt/trunk/cmake/Modules/AddCompilerRT.cmake:143
@@ -142,1 +142,3 @@
+# Unit tests on Mac depend on Foundation.
This comment is misleading. This build config is for compiler-rt, not unit tests.

Comment at: compiler-rt/trunk/lib/asan/tests/CMakeLists.txt:68
@@ -67,3 @@
-  list(APPEND ASAN_UNITTEST_COMMON_LINKFLAGS -framework Foundation)
Why remove this line? The tests actually do depend on Foundation.


More information about the llvm-commits mailing list