[PATCH 02/11] Support the new DiagnosticRemarks
simbuerg at fim.uni-passau.de
Tue Jun 10 04:14:01 PDT 2014
-----BEGIN PGP SIGNED MESSAGE-----
>> Are you saying we call this even if -Rpass was not specified.
>> Did you check the compile-time impact of this on a larger file?
>> Or maybe the LLVM test-suite?
> No, I have not tested the compile-time impact. Unfortunately we do
> not have access to the clang command line flags in opt afaik. I
> could check if the flag is enabled in opt easily but not in clang.
> So either we emit them all the time (1), or emit them as soon as
> the user passes the polly-detect-track-failures option (2).
> (1) might be bad in terms of compile-time. (2) is bad, if the clang
> user has to know that he needs polly-detect-track-failures in
> addition to -Rpass=".*"
> Would be easier to have a way of checking that the remarks are
> requested by the user.
Forget that, masking it with polly-detect-track-failures is perfectly
University of Passau - Programming Group
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (GNU/Linux)
-----END PGP SIGNATURE-----
More information about the llvm-commits