[PATCH] PR19958 wrong code at -O1 and above on x86_64-linux-gnu (InstCombine)

Rafael EspĂ­ndola rafael.espindola at gmail.com
Mon Jun 9 15:49:16 PDT 2014

On 9 June 2014 16:33, Sanjay Patel <spatel at rotateright.com> wrote:
> I'm not sure what LLVM test case policy is, but I think it would be good to have contra-test cases too. Eg, a test case that doesn't specify 'exact', a test case that isn't eq/ne - these would ensure that your code is not firing when it wasn't intended. Also, can you include a 'ne' test?

Yes, these are really good suggestions.

This codepath is somewhat hard to reach because of some issues with
instcombine that make it reachable only in larger testcases (see
pr19985). But it is still a good idea to have the basic tests. If we
fix the instcombine ordering, they would already be in place.


More information about the llvm-commits mailing list